From e3d2460bbb42d7710191569f88069044cfb9d8cf Mon Sep 17 00:00:00 2001
From: John Wesley Walker III <81404201+jww3@users.noreply.github.com>
Date: Wed, 23 Oct 2024 15:59:08 +0200
Subject: [PATCH] Expand unit test coverage (#1946)
---
__test__/url-helper.test.ts | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/__test__/url-helper.test.ts b/__test__/url-helper.test.ts
index 27f6606..57cb28f 100644
--- a/__test__/url-helper.test.ts
+++ b/__test__/url-helper.test.ts
@@ -24,13 +24,50 @@ describe('getServerUrl tests', () => {
})
describe('isGhes tests', () => {
+ const pristineEnv = process.env
+
+ beforeEach(() => {
+ jest.resetModules()
+ process.env = {...pristineEnv}
+ })
+
+ afterAll(() => {
+ process.env = pristineEnv
+ })
+
it('basics', async () => {
+ delete process.env['GITHUB_SERVER_URL']
expect(urlHelper.isGhes()).toBeFalsy()
expect(urlHelper.isGhes('https://github.com')).toBeFalsy()
expect(urlHelper.isGhes('https://contoso.ghe.com')).toBeFalsy()
expect(urlHelper.isGhes('https://test.github.localhost')).toBeFalsy()
expect(urlHelper.isGhes('https://src.onpremise.fabrikam.com')).toBeTruthy()
})
+
+ it('returns false when the GITHUB_SERVER_URL environment variable is not defined', async () => {
+ delete process.env['GITHUB_SERVER_URL']
+ expect(urlHelper.isGhes()).toBeFalsy()
+ })
+
+ it('returns false when the GITHUB_SERVER_URL environment variable is set to github.com', async () => {
+ process.env['GITHUB_SERVER_URL'] = 'https://github.com'
+ expect(urlHelper.isGhes()).toBeFalsy()
+ })
+
+ it('returns false when the GITHUB_SERVER_URL environment variable is set to a GitHub Enterprise Cloud-style URL', async () => {
+ process.env['GITHUB_SERVER_URL'] = 'https://contoso.ghe.com'
+ expect(urlHelper.isGhes()).toBeFalsy()
+ })
+
+ it('returns false when the GITHUB_SERVER_URL environment variable has a .localhost suffix', async () => {
+ process.env['GITHUB_SERVER_URL'] = 'https://mock-github.localhost'
+ expect(urlHelper.isGhes()).toBeFalsy()
+ })
+
+ it('returns true when the GITHUB_SERVER_URL environment variable is set to some other URL', async () => {
+ process.env['GITHUB_SERVER_URL'] = 'https://src.onpremise.fabrikam.com'
+ expect(urlHelper.isGhes()).toBeTruthy()
+ })
})
describe('getServerApiUrl tests', () => {